pythonPackages.colorgram: init at 1.2.0 #75896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsam
reviewed
Dec 18, 2019
| meta = with stdenv.lib; { | ||
| description = "A Python module for extracting colors from images. Get a palette of any picture!"; | ||
| homepage = https://github.com/obskyr/colorgram.py; | ||
| license = licenses.mit; |
There was a problem hiding this comment.
would you mind adding yourself as maintainer?
jonringer
reviewed
Dec 19, 2019
| }; | ||
|
|
||
| propagatedBuildInputs = [ pillow ]; | ||
|
|
There was a problem hiding this comment.
please add tests, you may need to check out from git hub
writing colorgram.py.egg-info/PKG-INFO
writing dependency_links to colorgram.py.egg-info/dependency_links.txt
writing requirements to colorgram.py.egg-info/requires.txt
writing top-level names to colorgram.py.egg-info/top_level.txt
reading manifest file 'colorgram.py.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'colorgram.py.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
tests will ensure that your package isn't broken by version bumps
| version = "1.2.0"; | ||
|
|
||
| src = fetchPypi { | ||
| inherit pname; |
There was a problem hiding this comment.
Suggested change
| inherit pname; | |
| inherit pname version; |
|
|
||
| src = fetchPypi { | ||
| inherit pname; | ||
| inherit version; |
There was a problem hiding this comment.
Suggested change
| inherit version; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @