Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

franz: fix Exec substitution in franz.desktop #75859

Merged
merged 1 commit into from Dec 18, 2019
Merged

franz: fix Exec substitution in franz.desktop #75859

merged 1 commit into from Dec 18, 2019

Conversation

davidtwco
Copy link
Member

Motivation for this change

Fixes #75819.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc me!

@davidtwco
franz: fix Exec substitution in franz.desktop
0ede4e0 
Signed-off-by: David Wood <david.wood@codeplay.com>
@teto
Copy link
Member

teto commented Dec 18, 2019

@GrahamcOfBorg build franz

@teto teto merged commit 05aa59a into NixOS:master Dec 18, 2019
@davidtwco davidtwco deleted the franz-fix-desktop-exec branch December 19, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Franz has incorrect executable in franz.desktop
2 participants
@davidtwco @teto