Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfdyndns: fix broken build #75865

Closed
wants to merge 1 commit into from

Conversation

voanhduy1512
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

The change in nixos/modules/services/misc/cfdyndns.nix is unrelated. Can you make this a different commit?

It also seems you've made this an update, but the commit doesn't reflect this being done.
Can you change version and have the commit message as standard in nixpkgs

cfdyndns: $old_version -> $new_version, fix build

@voanhduy1512
Copy link
Contributor Author

The change in nixos/modules/services/misc/cfdyndns.nix is not related but the old 5 minutes syntax is not validate and systemd reject it. But sure i can move it to another commit.
Also cfdyndns haven't release a new version. I just update it to latest git commit to make it be able to build successfully, so not sure if i should ping cfdyndns side to ask them release new version and update this PR or put commit hash in the commit message?

@colemickens
Copy link
Member

I cut a new tagged release: v0.0.2 on cfdyndns in case it helps. I didn't push a release tarball or anything, but the tag is there so you can use it in this PR.

@stale
Copy link

stale bot commented Jun 18, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 18, 2020
@worldofpeace
Copy link
Contributor

This is stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants