Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.7.0 -> 1.7.1 #75860

Merged
merged 1 commit into from Dec 18, 2019
Merged

matrix-synapse: 1.7.0 -> 1.7.1 #75860

merged 1 commit into from Dec 18, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 18, 2019

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.7.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member Author

Ma27 commented Dec 18, 2019

Btw should we backport 1.7.x to release-19.09?

@pacien
Copy link
Contributor

pacien commented Dec 18, 2019

The linked release note says:

This release includes several security fixes as well as a fix to a bug exposed by the security fixes. All previous releases of Synapse are affected. Administrators are encouraged to upgrade as soon as possible.

So yes, we have to backport this @Ma27.

@pacien
Copy link
Contributor

pacien commented Dec 18, 2019 •
edited

@ofborg test matrix-synapse

(Can we enable automatic testing with NixOS tests for this package?)

@Ma27
Copy link
Member Author

Ma27 commented Dec 18, 2019

Ok I missed the "all synapse versions are affected part", sorry! 🤦‍♂️

As soon as this is reviewed by some more folks, I'll merge and backport!

@Ma27 Ma27 added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 18, 2019
andir
andir approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ma27 the changes seem okay. Feel free to merge.

@WilliButz WilliButz merged commit ad7c7cf into NixOS:master Dec 18, 2019
@Ma27 Ma27 deleted the bump-matrix-synapse branch December 18, 2019 23:58
@tokudan tokudan mentioned this pull request Dec 19, 2019
Closed
10 tasks
@Ma27
Copy link
Member Author

Ma27 commented Dec 19, 2019

Backported the changes as 71738bf, 7695df5 and 5c4059d.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 19, 2019
@Ekleog
Copy link
Member

Ekleog commented Dec 19, 2019

@pacien (Can we enable automatic testing with NixOS tests for this package?)

This would be something like adding passthru.tests.nixos-test = nixosTests.matrix-synapse; along with adding nixosTests in the arguments to the package.

I planned to do that someday (as well as for all other nixos tests), but have been under the water for more than a year… :( feel free to submit a PR with changes like that! (that said, for it to actually work, we'll have to wait for NixOS/ofborg#410 to get merged and deployed)

Ma27 added a commit that referenced this pull request Dec 19, 2019
@Ma27
matrix-synapse: expose nixos-test in derivation
e4b9156 
As proposed during the last matrix-synapse bump[1].

[1] #75860 (comment)
@Ma27
Copy link
Member Author

Ma27 commented Dec 19, 2019

As this pattern seems to be a thing now, I added this to matrix-synapse as well: e4b9156

@Ekleog
Copy link
Member

Ekleog commented Dec 19, 2019

\o/ thank you!

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 10, 2020
@Ma27 @dtzWill
matrix-synapse: expose nixos-test in derivation
bf25dcc 
As proposed during the last matrix-synapse bump[1].

[1] NixOS#75860 (comment)

(cherry picked from commit e4b9156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@andir andir andir approved these changes

@pacien pacien pacien approved these changes

@Vskilet Vskilet Vskilet approved these changes

@Ekleog Ekleog Awaiting requested review from Ekleog

@mguentner mguentner Awaiting requested review from mguentner

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Ma27 @pacien @Ekleog @Ralith @andir @Vskilet @WilliButz