Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lgogdownloader: fix build #75862

Merged
merged 2 commits into from Dec 19, 2019
Merged

lgogdownloader: fix build #75862

merged 2 commits into from Dec 19, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 18, 2019

Motivation for this change

fixes #75836
cc: @alexarice

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@teto
Copy link
Member

teto commented Dec 18, 2019 •
edited by c0bw3b

maybe sthg to report upstream

Testing MemberTemplateIs/BehavesSameAsNamedIs: OK
* Detail of EscapeSequenceTest/writeEscapeSequence test failure:
/build/source/src/test_lib_json/main.cpp(3370): expected == result
  Expected: '["\"","\\","\b","\f","\n","\r","\t","\u0278","\ud852\udf62"]
  '
  Actual  : '["\"","\\","\b","\f","\n","\r","\t","ɸ","𤭢"]
  '
101/102 tests passed (1 failure(s))
make[2]: *** [src/test_lib_json/CMakeFiles/jsoncpp_test.dir/build.make:117: src/test_lib_json

@marsam
Copy link
Contributor Author

marsam commented Dec 19, 2019

upstream issue open-source-parsers/jsoncpp#1120

jonringer
jonringer approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[3 built, 3 copied (1.0 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75862
1 package were built:
lgogdownloader

@teto
Copy link
Member

teto commented Dec 19, 2019

seems like a patch is already available for jsoncpp in the issue you mentioned. You can update the jsonccp package here or contact the maintainers.

@marsam
Copy link
Contributor Author

marsam commented Dec 19, 2019

sure! I've added the patch for aarch64

@ofborg ofborg bot requested review from ttuegel and cpages December 19, 2019 14:58
@teto
Copy link
Member

teto commented Dec 19, 2019

thanks !

@teto teto merged commit 59edab3 into NixOS:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@cpages cpages Awaiting requested review from cpages

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lgogdownloader fails to build
3 participants
@marsam @teto @jonringer