Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wfuzz: init at 2.4.2 #76058

Merged
merged 1 commit into from Dec 21, 2019
Merged

wfuzz: init at 2.4.2 #76058

merged 1 commit into from Dec 21, 2019

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

Make wfuzz available on Nix.

Contains the related Python3 package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If want this available as a python package and as an application. I would put the expression in python-modules, and then use with python3Packages; toPythonApplication wfuzz;

the problem right now is that you are introducing the python37 interpreter to all version of the python modules currently

@Pamplemousse
Copy link
Member Author

Changed.

I don't quite understand what the problem is though...

@jonringer
Copy link
Contributor

your original expression had python3Packages, which is aliased to python37Packages.

That means for python2, it was actually building and propagating the python37 interpreter for the python2 package

@jonringer
Copy link
Contributor

to have it your original way, you would need to override the interpreter for each python module, similiar to

nixpkgs/pkgs/top-level/python-packages.nix

Line 254 in 1c15955

avahi = toPythonModule (pkgs.avahi.override {

@Pamplemousse
Copy link
Member Author

Thanks for the explanation!

jonringer
jonringer approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has tests 👍
executable shows usage

[6 built, 15 copied (31.0 MiB), 5.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76058
3 package were built:
python27Packages.wfuzz wfuzz python38Packages.wfuzz

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.wfuzz wfuzz python38Packages.wfuzz

@jonringer
Copy link
Contributor

arch build is broken for unrelated reasons

@jonringer jonringer merged commit 6306baa into NixOS:master Dec 21, 2019
@Pamplemousse Pamplemousse deleted the wfuzz branch November 19, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pamplemousse @jonringer