Add mimeType to discord package #76057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/mimetype-issue-with-discord-package/5143/5 |
danbst
reviewed
Dec 19, 2019
| @@ -48,6 +48,7 @@ in stdenv.mkDerivation rec { | |||
| inherit desktopName; | |||
| genericName = meta.description; | |||
| categories = "Network;InstantMessaging;"; | |||
| mimeType="x-scheme-handler/discord"; | |||
There was a problem hiding this comment.
Suggested change
| mimeType="x-scheme-handler/discord"; | |
| mimeType = "x-scheme-handler/discord"; |
There was a problem hiding this comment.
8d53656 Fixed spacing
tadeokondrak
approved these changes
Dec 19, 2019
|
@skykanin thanks and welcome to contributors guild! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/discord-mimetype-issue-with-version-bump/6036/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A bug in the discord package cause url links to not be opened in the browser when clicked.
Things done
Added the
mimeTypeproperty to the packagesandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @