Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome2.GConf: python2 -> python3 #75919

Merged
merged 1 commit into from Dec 19, 2019
Merged

gnome2.GConf: python2 -> python3 #75919

merged 1 commit into from Dec 19, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 19, 2019 •
edited

Borrowing fedora's 2to3 trick:
https://src.fedoraproject.org/rpms/GConf2/blob/master/f/GConf2.spec#_90

(thank you, @worldofpeace!)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

worldofpeace
worldofpeace approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, we really shouldn't even care about this script at this point so it's just being nice 😄

@grahamc grahamc changed the base branch from master to staging December 19, 2019 03:30
@FRidh FRidh added this to Ready in Python 2 deprecation Dec 19, 2019
@FRidh FRidh added this to Ready in Staging Dec 19, 2019
@FRidh FRidh merged commit a52749e into NixOS:staging Dec 19, 2019
Staging automation moved this from Ready to Done Dec 19, 2019
Python 2 deprecation automation moved this from Ready to Done Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Python 2 deprecation
  
Done
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @worldofpeace @FRidh