Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packer: 1.4.4 -> 1.5.0 #75948

Merged
merged 1 commit into from Dec 19, 2019
Merged

packer: 1.4.4 -> 1.5.0 #75948

merged 1 commit into from Dec 19, 2019

Conversation

endocrimes
Copy link
Member

@endocrimes endocrimes commented Dec 19, 2019 •
edited

Motivation for this change

Updating Packer to latest because they now also support HCL rather than only JSON.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • N/A Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @cstrahan @zimbatm

@ofborg ofborg bot requested review from zimbatm, ehmry and cstrahan December 19, 2019 15:07
@zimbatm
Copy link
Member

zimbatm commented Dec 19, 2019

nice! Just confirmed that it compiles with nix-review

@zimbatm zimbatm merged commit b8afcb7 into NixOS:master Dec 19, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@endocrimes @dtzWill
packer: 1.4.4 -> 1.5.0 (NixOS#75948)
f182499 
(cherry picked from commit b8afcb7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

@ehmry ehmry Awaiting requested review from ehmry

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@endocrimes @zimbatm