Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcl: fix dangling symlink #75947

Merged
merged 1 commit into from Dec 20, 2019
Merged

tcl: fix dangling symlink #75947

merged 1 commit into from Dec 20, 2019

Conversation

eraserhd
Copy link
Contributor

Motivation for this change

The recent weechat version update fails to build on Darwin now. They
changed how the TCL library is detected, and it is now attempting to
link against the dangling symlink, causing the build to fail.

Things done

Verified that the derivation's hash does not change on Linux.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vrthra

@ofborg ofborg bot requested a review from vrthra December 19, 2019 15:11
@eraserhd eraserhd mentioned this pull request Dec 19, 2019
Merged
10 tasks
@marsam marsam merged commit 039a5bd into NixOS:staging Dec 20, 2019
@marsam
Copy link
Contributor

marsam commented Dec 20, 2019

Thanks!

@eraserhd eraserhd mentioned this pull request Dec 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@nh2 nh2 nh2 approved these changes

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eraserhd @marsam @nh2