Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcdf: 4.6.1 -> 4.7.3 #76077

Merged
merged 1 commit into from Dec 20, 2019
Merged

netcdf: 4.6.1 -> 4.7.3 #76077

merged 1 commit into from Dec 20, 2019

Conversation

bcdarwin
Copy link
Member

and enable tests as per unmerged #56830

A couple of reverse deps fail to build (mysqlWorkbench and python*Packages.ovito) but these failures seem to be due to Qt-related breakage.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

and enable tests as per unmerged NixOS#56830
@@ -37,9 +38,12 @@ in stdenv.mkDerivation rec {
"--enable-netcdf-4"
"--enable-dap"
"--enable-shared"
"--disable-dap-remote-tests"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the disable ? maybe put an inline comment

Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review run looks good.

@markuskowa markuskowa mentioned this pull request Dec 20, 2019
10 tasks
@teto teto merged commit 2ea7b81 into NixOS:master Dec 20, 2019
@bcdarwin bcdarwin deleted the update-netcdf branch December 20, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants