Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.dask-ml: 1.1.1 -> 1.2.0 #76047

Merged
merged 1 commit into from Jan 22, 2020
Merged

python3Packages.dask-ml: 1.1.1 -> 1.2.0 #76047

merged 1 commit into from Jan 22, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 19, 2019 •
edited

Motivation for this change

noticed it was broken on hydra :(

EDIT:
i guess with updates to the dask package, fsspec is no loner a dependency, re-purposed PR for version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76047
2 package were built:
python37Packages.dask-ml python38Packages.dask-ml

@ofborg ofborg bot requested a review from costrouc December 19, 2019 17:34
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.aplpy python37Packages.caffe python37Packages.dask python37Packages.dask-glm python37Packages.dask-jobqueue python37Packages.dask-ml python37Packages.dask-mpi python37Packages.dask-xgboost python37Packages.datashader python37Packages.distributed python37Packages.fsspec python37Packages.glymur python37Packages.image-match python37Packages.intake python37Packages.pyfftw python37Packages.scikitimage python37Packages.streamz python37Packages.stumpy python37Packages.sunpy python38Packages.fsspec

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.aplpy python37Packages.caffe python37Packages.dask python37Packages.dask-glm python37Packages.dask-jobqueue python37Packages.dask-ml python37Packages.dask-mpi python37Packages.dask-xgboost python37Packages.datashader python37Packages.distributed python37Packages.fsspec python37Packages.glymur python37Packages.image-match python37Packages.intake python37Packages.pyfftw python37Packages.scikitimage python37Packages.streamz python37Packages.stumpy python37Packages.sunpy python38Packages.fsspec

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.dask-ml python38Packages.dask-ml

@jonringer
Copy link
Contributor Author

removed fsspec bump commit, didn't mean to kick off the large ofborg build job

@jonringer
Copy link
Contributor Author

i guess with updates to the dask package, fsspec is no loner a dependency, re-purposed PR for version bump

@jonringer jonringer changed the title python3Packages.dask-ml: add fsspec dependency python3Packages.dask-ml: 1.1.1 -> 1.2.0 Jan 9, 2020
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.dask-ml python38Packages.dask-ml

@jonringer
Copy link
Contributor Author

darwin failures not related

@jonringer jonringer merged commit fcb3cf3 into NixOS:master Jan 22, 2020
@jonringer jonringer deleted the fix-python-dask-ml branch January 22, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer