Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry: 0.12.17 -> 1.0.0 #75872

Closed
wants to merge 1 commit into from
Closed

poetry: 0.12.17 -> 1.0.0 #75872

wants to merge 1 commit into from

Conversation

robertodr
Copy link
Contributor

@robertodr robertodr commented Dec 18, 2019 •
edited

Motivation for this change

Upgrades poetry to its latest released version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jbaum98

@ofborg ofborg bot requested a review from jbaum98 December 18, 2019 14:19
andir
andir requested changes Dec 18, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails to compile for me. Error is very similar to what ofBorg reports:

installing
Executing pipInstallPhase
/build/cleo-0.7.6/dist /build/cleo-0.7.6
Processing ./cleo-0.7.6-py3-none-any.whl
ERROR: Could not find a version that satisfies the requirement clikit<0.5.0,>=0.4.0 (from cleo==0.7.6) (from versions: none)
ERROR: No matching distribution found for clikit<0.5.0,>=0.4.0 (from cleo==0.7.6)
builder for '/nix/store/6f6y2vwgwr0zy48pxjphnkb1241wvc4i-python3.7-cleo-0.7.6.drv' failed with exit code 1
```

@robertodr
Copy link
Contributor Author

Yes, this depends on #75873 Should I compact the two PRs into one?

@jonringer
Copy link
Contributor

you could also wait for the other get merged

@jonringer
Copy link
Contributor

although, seeing as this doesn't have many rebuilds, and the other is already pushing a few hundred, I would just cherry-pick this on top of the other PR

@robertodr
Copy link
Contributor Author

Done, I am closing this one in favor of #75873

@robertodr robertodr closed this Dec 19, 2019
@robertodr robertodr deleted the upgrade-poetry branch December 19, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@jbaum98 jbaum98 Awaiting requested review from jbaum98

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertodr @jonringer @andir