Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu: 4.1.0 -> 4.2.0, including patch for minor CVE-2019-15890 #76065

Merged
merged 2 commits into from Jan 2, 2020
Merged

qemu: 4.1.0 -> 4.2.0, including patch for minor CVE-2019-15890 #76065

merged 2 commits into from Jan 2, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Dec 19, 2019 •
edited

Motivation for this change

Mostly the bump but also https://nvd.nist.gov/vuln/detail/CVE-2019-15890

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from edolstra December 19, 2019 21:06
@risicle
Copy link
Contributor Author

risicle commented Dec 19, 2019

@GrahamcOfBorg build aqemu vagrant minikube cloud-utils

@blitz
Copy link
Contributor

blitz commented Dec 26, 2019 •
edited

I gave this a quick shot. Looks good.

Testing done

  • Booting grml LiveCD with qemu-system-x86_64
  • Booting RISC-V kernel in qemu-system-riscv64

@wedens
Copy link

wedens commented Dec 30, 2019

Unfortunately, qemu is already updated to 4.1 in unstable, but libvirt is still 5.4.0. so I'll mention it here.

Using some vpindex hyper-v enlightement with qemu > 4.0 and libvirt < 5.6.0 will result in this error:

"error: unsupported configuration: host doesn't support hyperv 'vpindex' feature"

Many other enlightements depend on vpindex presence.

It probably worth its own issue, but I just want to bring attention.

https://www.redhat.com/archives/libvir-list/2019-July/msg01642.html

@fpletz fpletz merged commit 5338dd7 into NixOS:master Jan 2, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 18, 2020
@fpletz @dtzWill
Merge pull request NixOS#76065 from risicle/ris-qemu-4.2.0
735b125 
qemu: 4.1.0 -> 4.2.0, including patch for minor CVE-2019-15890
(cherry picked from commit 5338dd7)
This was referenced Feb 26, 2020
Closed
Merged
@zowoq zowoq mentioned this pull request Oct 24, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @blitz @wedens @fpletz