Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireguard-tools: 0.0.20191212 -> 0.0.20191219 #75920

Merged
merged 1 commit into from Dec 19, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 19, 2019

Motivation for this change

This version fixes the build on Linux 5.4.5, which currently fails with https://gist.github.com/ivan/6aedffc51d32ac618d5970a76da9f381

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @elseym @ericsagnes @Mic92 @zx2c4 @globin @Ma27

@jonringer
Copy link
Contributor

@GrahamcOfBorg test nixosTests.wireguard nixosTests.wireguard-generated nixosTests.wireguard-namespaces

@jonringer
Copy link
Contributor

@GrahamcOfBorg test wireguard wireguard-generated wireguard-namespaces

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[17 built, 4 copied (256.1 MiB), 120.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75920
2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.wireguard linuxPackages_hardkernel_latest.wireguard

15 package were built:
linuxPackages-libre.wireguard linuxPackages.wireguard linuxPackages_4_14.wireguard linuxPackages_4_4.wireguard linuxPackages_4_9.wireguard linuxPackages_5_3.wireguard linuxPackages_5_4.wireguard linuxPackages_hardened.wireguard linuxPackages_latest-libre.wireguard linuxPackages_latest_hardened.wireguard linuxPackages_latest_xen_dom0.wireguard linuxPackages_testing_bcachefs.wireguard linuxPackages_testing_hardened.wireguard linuxPackages_xen_dom0.wireguard wireguard-tools

merge if tests pass

@jonringer jonringer merged commit cbd6771 into NixOS:master Dec 19, 2019
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 19, 2019
@Ma27
Copy link
Member

Ma27 commented Dec 19, 2019

Will backport this now. Linux 5.4 is also available on release-19.09 (as linuxPackages_latest which I'm currently using btw) and WireGuard breaks with kernel 5.4 here as well.

@Ma27
Copy link
Member

Ma27 commented Dec 19, 2019

Backported the last two bumps as f80c916 and 7cb5ccd.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants