Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: change alias from python2 to python3 #76048

Closed
wants to merge 1 commit into from
Closed

python: change alias from python2 to python3 #76048

wants to merge 1 commit into from

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Dec 19, 2019

Motivation for this change

The python 2 end-of-life is coming up fast, on the 1st of January 2020. As such, I think we should discourage its use as much as possible in nixpkgs.

Hopefully, anything using the unversioned alias shouldn't depend too much on which version of Python it winds up with, but I'm sure this is going to break an awful lot of packages.

I've tested whether a handful of prominent packages continue to build and some do and some don't. There's definitely a lot of work to do to get this into a state where it doesn't break too much.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

python: change alias from python2 to python3
7491f3e 
The end-of-life for python2 is coming up fast (1st of January 2020) and
as such I think we should be trying as hard as we can to discourage its
use in nixpkgs. Hopefully, anything using the unversioned alias
shouldn't depend too much on which version of python it winds up with,
but I'm sure this is going to break an awful lot of packages.
@Taneb Taneb requested a review from FRidh as a code owner December 19, 2019 17:35
@FRidh
Copy link
Member

FRidh commented Dec 19, 2019

I have no time to find the relevant issue now, but no, it's decided that this approach will not be taken.

@FRidh FRidh closed this Dec 19, 2019
@FRidh FRidh added this to Done in Python 2 deprecation via automation Dec 19, 2019
@edolstra
Copy link
Member

I think the result of previous discussion on this topic was that it would be better to remove the python attribute, since switching it to point to python3 would cause a lot of silent breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: documentation
Projects
Python 2 deprecation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taneb @FRidh @edolstra