Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrayfire: build with current gcc version #76050

Merged
merged 1 commit into from Dec 19, 2019
Merged

arrayfire: build with current gcc version #76050

merged 1 commit into from Dec 19, 2019

Conversation

robertodr
Copy link
Contributor

Motivation for this change

Lift the requirement stdenv = gcc6Stdenv.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @chessai

@chessai
Copy link
Member

chessai commented Dec 19, 2019

Did you attempt a build for this locally? I ran into issues using the default stdenv. Note that the CI here won't build arrayfire because cudatoolkit is closed source.

@robertodr
Copy link
Contributor Author

robertodr commented Dec 19, 2019 via email

@chessai
Copy link
Member

chessai commented Dec 19, 2019 •
edited

strange. i will start a build right now and report back. if it builds i'll approve. probably isn't making a difference here, but note that i always have sandboxing on, not sure if you do as well based off of the checkboxes.

@chessai
Copy link
Member

chessai commented Dec 19, 2019

LGTM.

@chessai
Copy link
Member

chessai commented Dec 19, 2019

thanks @robertodr !

@markuskowa markuskowa merged commit 2783a10 into NixOS:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chessai chessai chessai approved these changes

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertodr @chessai @markuskowa