Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tebreak, minia, last, bx-python, python-lzo #75900

Merged
merged 5 commits into from Dec 29, 2019
Merged

Tebreak, minia, last, bx-python, python-lzo #75900

merged 5 commits into from Dec 29, 2019

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Dec 18, 2019

Motivation for this change

Add tebreak and prerequisites.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use the "installable" path for packages in the commit message:

  pythonPackages.bx-python: init at XX

pkgs/development/python-modules/bx-python/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer reviewed Dec 19, 2019
View reviewed changes
pkgs/development/python-modules/bx-python/default.nix Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-lzo/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/last/default.nix Outdated Show resolved Hide resolved
@jbedo jbedo force-pushed the tebreak branch 3 times, most recently from ccafa9c to af9cad7 Compare December 19, 2019 22:38
jonringer
jonringer approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍
python patching looks right

https://github.com/NixOS/nixpkgs/pull/75900
8 package were built:
last minia python27Packages.python-lzo python37Packages.bx-python python37Packages.python-lzo python38Packages.bx-python python38Packages.python-lzo tebreak

@jonringer
Copy link
Contributor

@GrahamcOfBorg build last minia python27Packages.python-lzo python37Packages.bx-python python37Packages.python-lzo python38Packages.bx-python python38Packages.python-lzo tebreak

@jonringer
Copy link
Contributor

please disable darwin for minia and bx-python packages, unless you want to troubleshoot their failures: https://github.com/NixOS/nixpkgs/pull/75900/checks?check_run_id=357315508

@jbedo
Copy link
Contributor Author

jbedo commented Dec 20, 2019

Disabled darwin.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build last minia python27Packages.python-lzo python37Packages.bx-python python37Packages.python-lzo python38Packages.bx-python python38Packages.python-lzo tebreak

@jonringer
Copy link
Contributor

@GrahamcOfBorg build last minia python27Packages.python-lzo python37Packages.bx-python python37Packages.python-lzo python38Packages.bx-python python38Packages.python-lzo tebreak

@FRidh FRidh merged commit eda0186 into NixOS:master Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbedo @jonringer @FRidh