Building with your patch did eliminate the issue, but I still can't see the the indicator in Wingpanel sweat_smile

I've patched wingpanel for purity, so wingpanel-with-indicators takes a indicators argument so you can configure it.

with import ./. {};

pantheon.wingpanel-with-indicators.override {
  indicators = [
    monitor
  ] ++ pantheon.wingpanelIndicators;
}

I specifically didn't want it so it reads indicators from /run/current-system/sw/* (it makes things harder).

But I haven't added a nixos interface to this because there was no package extra package in nixos that had an extra indicator. I should do this now 👍 .

@kjuvi I don't think the directory structure here is best.
Can we add an applications/system like tools/system? What do you think?

@kjuvi I don't think the directory structure here is best.
Can we add an applications/system like tools/system? What do you think?

I was actually looking for this specific folder but since it didn't exist I just put it in applications/misc by default.

I'll add this folder and move the expression there 👍

@kjuvi It seems you've changed the package version to the rev of my patches. Can you return to https://github.com/stsdc/monitor/releases/tag/0.6.1, and just fetchpatch https://github.com/stsdc/monitor/commit/07d1984175fcaef2909029a387f830efd647471b.patch and https://github.com/stsdc/monitor/commit/ab2cfed150cd2a6b5c3fcee5297a65c1b429c674.patch. We should be using a released version.

I've patched wingpanel for purity, so wingpanel-with-indicators takes a indicators argument so you can configure it.

with import ./. {};

pantheon.wingpanel-with-indicators.override {
  indicators = [
    monitor
  ] ++ pantheon.wingpanelIndicators;
}

I specifically didn't want it so it reads indicators from /run/current-system/sw/* (it makes things harder).

But I haven't added a nixos interface to this because there was no package extra package in nixos that had an extra indicator. I should do this now +1 .

Okay so, if I understood correctly, it is the responsibility of the user to override his wingpanel if he wants the indicator ?

@kjuvi It seems you've changed the package version to the rev of my patches. Can you return to https://github.com/stsdc/monitor/releases/tag/0.6.1, and just fetchpatch https://github.com/stsdc/monitor/commit/07d1984175fcaef2909029a387f830efd647471b.patch and https://github.com/stsdc/monitor/commit/ab2cfed150cd2a6b5c3fcee5297a65c1b429c674.patch. We should be using a released version.

Woops, you're right, I'll revert this...

@kjuvi I've added options to configure wingpanel and switchboard plugins #76116.

But you can still build

with import ./. {};

pantheon.wingpanel-with-indicators.override {
  indicators = [ monitor ];
};

Note that without the prior PR it will be the only indicator in wingpanel.

Looks like there was a little issue with that PR after I merged it 776893e 😄
I tested the indicator, it works LGTM.

In the force push here, I added the updateScript attribute for https://github.com/NixOS/nixpkgs/tree/master/pkgs/desktops/pantheon/nixpkgs_github_update.