grpc: 1.25.0 -> 1.26.0 #75917
Merged
grpc: 1.25.0 -> 1.26.0 #75917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this causes ~150 rebuilds, staging might be more appropriate |
|
AFAIK ~150 rebuilds should be fine for master, I'm not sure if is written somewhere but according #nixos-dev, ~2500 is the "limit" #67976 (comment) |
|
I think it's more a courtesy to others hacking on master, so they don't have to build a potentially large number of packages to build the package they are modifying. Personally, I have a 3900X that generally eats through most builds :). |
|
sigh... tensorflow and pytorch are killing me when reviewing this :( |
|
<500 is typically fine for master. With @r-ryantm we typically put it at 100~500 because it's often a batch of changes. |
|
there is a regression in one of these packages, but I'm not sure which: |
jonringer
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
LGTM
failures seem to be mostly related to google python packages are broken, or they are broken on master
[48 built (31 failed), 58 copied (1890.5 MiB), 807.9 MiB DL]
error: build of '/nix/store/nw7b7wbhrjf193mp0dpmhdn5zn2dc8mi-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/75917
16 package are marked as broken and were skipped:
linuxPackages_4_4.sysdig linuxPackages_4_9.sysdig linuxPackages_hardkernel_4_14.sysdig linuxPackages_hardkernel_latest.sysdig python27Packages.baselines python27Packages.dm-sonnet python27Packages.edward python27Packages.graph_nets python27Packages.tensorflow python27Packages.tensorflow-build python27Packages.tensorflow-probability python27Packages.tensorflowWithCuda python27Packages.tensorflowWithoutCuda python27Packages.tflearn python37Packages.pyro-ppl python38Packages.pyro-ppl
51 package failed to build:
dvc-with-remotes python27Packages.tensorflow-bin python37Packages.arviz python37Packages.baselines python37Packages.dm-sonnet python37Packages.edward python37Packages.google_cloud_automl python37Packages.google_cloud_bigquery python37Packages.google_cloud_bigtable python37Packages.google_cloud_container python37Packages.google_cloud_datastore python37Packages.google_cloud_dns python37Packages.google_cloud_error_reporting python37Packages.google_cloud_logging python37Packages.google_cloud_resource_manager python37Packages.google_cloud_runtimeconfig python37Packages.google_cloud_spanner python37Packages.google_cloud_storage python37Packages.graph_nets python37Packages.optuna python37Packages.pytorch python37Packages.pytorchWithCuda python37Packages.rl-coach python37Packages.tensorflow python37Packages.tensorflow-bin python37Packages.tensorflow-probability python37Packages.tensorflowWithCuda python37Packages.tflearn python37Packages.torchvision python38Packages.baselines python38Packages.dm-sonnet python38Packages.edward python38Packages.google_cloud_automl python38Packages.google_cloud_bigtable python38Packages.google_cloud_container python38Packages.google_cloud_datastore python38Packages.google_cloud_dns python38Packages.google_cloud_error_reporting python38Packages.google_cloud_logging python38Packages.google_cloud_resource_manager python38Packages.google_cloud_runtimeconfig python38Packages.google_cloud_spanner python38Packages.google_cloud_storage python38Packages.graph_nets python38Packages.pytorch python38Packages.pytorchWithCuda python38Packages.tensorflow python38Packages.tensorflow-probability python38Packages.tensorflowWithCuda python38Packages.tflearn python38Packages.torchvision
73 package were built:
google-cloud-cpp grpc linuxPackages-libre.sysdig linuxPackages.sysdig linuxPackages_4_14.sysdig linuxPackages_5_3.sysdig linuxPackages_5_4.sysdig linuxPackages_hardened.sysdig linuxPackages_latest-libre.sysdig linuxPackages_latest_hardened.sysdig linuxPackages_latest_xen_dom0.sysdig linuxPackages_testing_bcachefs.sysdig linuxPackages_testing_hardened.sysdig linuxPackages_xen_dom0.sysdig python27Packages.grpc_google_iam_v1 python27Packages.grpcio python27Packages.grpcio-gcp python27Packages.grpcio-tools python27Packages.tensorflow-tensorboard python37Packages.google_api_core python37Packages.google_cloud_asset python37Packages.google_cloud_bigquery_datatransfer python37Packages.google_cloud_core python37Packages.google_cloud_dataproc python37Packages.google_cloud_dlp python37Packages.google_cloud_firestore python37Packages.google_cloud_iot python37Packages.google_cloud_kms python37Packages.google_cloud_language python37Packages.google_cloud_monitoring python37Packages.google_cloud_pubsub python37Packages.google_cloud_redis python37Packages.google_cloud_securitycenter python37Packages.google_cloud_speech python37Packages.google_cloud_tasks python37Packages.google_cloud_texttospeech python37Packages.google_cloud_trace python37Packages.google_cloud_translate python37Packages.google_cloud_videointelligence python37Packages.google_cloud_vision python37Packages.google_cloud_websecurityscanner python37Packages.grpc_google_iam_v1 python37Packages.grpcio python37Packages.grpcio-gcp python37Packages.grpcio-tools python37Packages.tensorflow-tensorboard python38Packages.google_api_core python38Packages.google_cloud_asset python38Packages.google_cloud_bigquery_datatransfer python38Packages.google_cloud_core python38Packages.google_cloud_dataproc python38Packages.google_cloud_dlp python38Packages.google_cloud_firestore python38Packages.google_cloud_iot python38Packages.google_cloud_kms python38Packages.google_cloud_language python38Packages.google_cloud_pubsub python38Packages.google_cloud_redis python38Packages.google_cloud_securitycenter python38Packages.google_cloud_speech python38Packages.google_cloud_tasks python38Packages.google_cloud_texttospeech python38Packages.google_cloud_trace python38Packages.google_cloud_translate python38Packages.google_cloud_videointelligence python38Packages.google_cloud_vision python38Packages.google_cloud_websecurityscanner python38Packages.grpc_google_iam_v1 python38Packages.grpcio python38Packages.grpcio-gcp python38Packages.grpcio-tools python38Packages.tensorflow-tensorboard sysdig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Changelog: https://github.com/grpc/grpc/releases/tag/v1.26.0
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @