Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.dhall_1_28_0: fix overrides so it builds #76079

Merged
merged 1 commit into from Dec 20, 2019

Conversation

cdepillabout
Copy link
Member

This PR fixes dhall_1_28_0, dhall-bash_1_0_25, and dhall-json_1_6_0 so
they build.

They all require a newer version of prettyprinter than we get from the
LTS package set.

This is from #75931 by @ijaketak.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

This PR fixes dhall_1_28_0, dhall-bash_1_0_25, and dhall-json_1_6_0 so
they build.

They all require a newer version of prettyprinter than we get from the
LTS package set.

This is from NixOS#75931 by @ijaketak.

Co-authored-by: Keito Kajitani <ijaketak@gmail.com>
@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.dhall-bash_1_0_25 haskellPackages.dhall_1_28_0 haskellPackages.dhall-json_1_6_0

@cdepillabout
Copy link
Member Author

cdepillabout commented Dec 20, 2019

This builds cleanly on x86_64 and darwin, so I'm going to go ahead and merge in.

Thanks @ijaketak!

@cdepillabout cdepillabout merged commit 7bc89e2 into NixOS:haskell-updates Dec 20, 2019
@cdepillabout cdepillabout deleted the fix-dhall-1.28 branch December 20, 2019 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant