Python package set major updates #76059
Conversation
|
@jonringer feel free to force-push. |
|
Should also consider #65023 again |
|
can you revert the gym update 834a4f7?, because it requires python-opencv which is not in nixpkgs yet |
FRidh
force-pushed
the
python-unstable
branch
from
211c401
to
ea825f2
Compare
|
Done |
|
Could you point me to that |
|
Thanks. |
|
IIRC, we can also use the opencv package to make the bindings, the https://github.com/skvark/opencv-python repo is just there to publish the wheels. But tying to build from opencv-python is painful as it makes a lot of assumptions about network access, git, and cmake integration. |
|
Yes, we just need to build a dist-info folder that has the |
|
the only packages i can think of that use opencv-python are imgaug, baselines, and gym |
|
there's a PR to fix imgaug here: #67494 Although eventually, we should add it. I just don't have the will right now. |
|
did you want help stabilizing this? because I know a lot of leaf packages probably got broken |
|
Yes, I think we need to do such an upgrade again. I saw some of the PR's, and those are bound to cause regressions as well. With this PR/branch we can test them. I will actually be away for a week so probably need to rerun this after. |
|
I feel like now would be a good time to bump pytest and hypothesis |
Definitely! Thank you for looking at these packages. Next Sunday I'll be back and can have a look as well. |
jonringer
force-pushed
the
python-unstable
branch
from
3a043e9
to
8d4197a
Compare
|
had to revert sip bump, as it broke a lot of pyqt builds |
|
going to revert the boto/moto bumps apparently aws is a very fragile api |
jonringer
force-pushed
the
python-unstable
branch
from
8d4197a
to
03c1096
Compare
|
also reverted the major coverage bump, as that broke quite a few packages |
Not a mandatory dependency so remove it.
When `makeWrapperArgs` variable is not set, `declare -p makeWrapperArgs` will return with 1 and print an error message to stderr. I did not handle the non-existence case in b063340 because I thought `mk-python-derivation` will always define `makeWrapperArgs` but `wrapProgram` can be called independently. And even with `mk-python-derivation`, `makeWrappers` will not be set unless explicitly declared in the derivation because of NixOS/nix#1461. I was lead to believe that because the builds were succeeding and I confirmed that the mechanism fails when the variable is not defined and `-o nounset` is enabled. It appears that `wrapPython` setup hook is not running under `-o nounset`, though, invaldating the assumption. Now we are checking that the variable exists before checking its type, which will get rid of the warning and also prevent future error when `-o nounset` is enabled in the setup hook. For more information, see the discussion at a6bb2ed
as we already set
LANG = "${if python.stdenv.isDarwin then "en_US" else "C"}.UTF-8";
in `buildPythonPackage`.
This is related to issue #74904
|
Forgot to merge it into staging so that's why it went to staging-next... |
| @@ -8,11 +8,12 @@ | |||
|
|
|||
| buildPythonPackage rec { | |||
| pname = "gunicorn"; | |||
| version = "19.9.0"; | |||
| version = "20.0.4"; | |||
There was a problem hiding this comment.
FYI this change breaks apache-airflow build:
ERROR: Could not find a version that satisfies the requirement gunicorn<20.0,>=19.5.0 (from apache-airflow==1.10.5) (from versions: none)
ERROR: No matching distribution found for gunicorn<20.0,>=19.5.0 (from apache-airflow==1.10.5)
There was a problem hiding this comment.
opening a ticket is more action-able :), I unfortunately don't have time to look into this :(
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @