treewide: fix cargoSha256 (again) #76060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Dec 19, 2019
|
carnix is worse at the moment due the large amounts of nix expressions it generates. There is no alternative atm. |
alyssais
force-pushed
the
cargo-vendor
branch
from
d7363d6
to
5ac75b1
Compare
alyssais
force-pushed
the
cargo-vendor
branch
from
5ac75b1
to
7c9b60e
Compare
|
Why did the rustc update cause |
|
I'm also curious why this change didn't affect all rust packages. For example, it doesn't look as though |
|
Why did the rustc update cause `cargo vendor` output to change though?
What's the root cause here?
It looks like Cargo.lock files are no longer excluded. So only the
packages with dependencies containing Cargo.lock would have changed.
At least, that's what's changed for the one I looked at (rsclock, whose
vendored autocfg now includes Cargo.lock).
|
|
Wow really? That seems really odd, because I thought Cargo.lock was intentionally and explicitly excluded from dependencies. |
|
Wow really? That seems really odd, because I thought Cargo.lock was
intentionally and explicitly excluded from dependencies.
Yep. You can confirm yourself by building rsClock.cargoDeps before that
commit was merged from staging-next, and after, and comparing with
diffoscope.
It might not be that Cargo.lock specifically is now included, though.
Maybe there was some other change to inclusion logic made that just
happened to manifest as Cargo.lock beginning to be included in this
case.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previously: #62047
This time the change in
cargo vendoroutput was caused by a4fc84d.I hope that some time soon we can ban
buildRustPackagefrom Nixpkgs.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @