New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: nixos/vagrant-virtualbox-image: init #76071
Conversation
Introduce a new vagrant profile
This will ultimately replace the nix-community/nixbox project. Change the configuration.nix to not include the installation ISO to something like this: ```nix { config, lib, pkgs, modulesPath, ... }: { documentation.man.enable = false; documentation.nixos.enable = false; sound.enable = false; } ``` See nix-community/nixbox#38 Depends on NixOS/nixpkgs#76071
# 4. move the ovf to the fixed location | ||
mv *.ovf box.ovf | ||
|
||
# TODO: fix the checksum file instead of removing it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is it computed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked into it, which is why it was easier to remove :)
Co-Authored-By: Jörg Thalheim <Mic92@users.noreply.github.com>
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/building-openstack-images-and-development-vms-from-a-macos-host/9522/5 |
To test:
{ config, lib, pkgs, modulesPath, ... }:
{
documentation.man.enable = false;
documentation.nixos.enable = false;
sound.enable = false;
}
Starting in Vagrant
|
Starts after Rebuilt with a config including It's not clear to me how to modify
|
Awesome. Do you want to take this PR to the finish line? |
My Nix-fu is weak, so I would appreciate some advice on how to make an acceptable modification to the existing virtualbox expression to make the usb and audio stuff optional. Some kind of map of options with defaults? Alternatively, I could copy the guts of the virtualbox script into the vagrant virtualbox instead of including it. I’m worried it would be rejected for code duplication though 😄 |
It looks like be25539 took care of that for me. I'll update my PR to match. |
Replaced by #101120 |
Introduce a new vagrant profile
Build vagrant boxes directly out of nixos configurations instead of using packer like in nix-community/nixbox project.
This is untested for now as I don't have a virtualbox setup at the moment.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @