iOS with xcode 11 cherry pick for 19.09 #76070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
changed the title
Ericson2314
approved these changes
Dec 19, 2019
| @@ -10,7 +10,7 @@ | |||
| , # GHC can be built with system libffi or a bundled one. | |||
| libffi ? null | |||
|
|
|||
| , useLLVM ? !stdenv.targetPlatform.isx86 | |||
| , useLLVM ? !stdenv.targetPlatform.isx86 || (stdenv.targetPlatform.isMusl && stdenv.hostPlatform != stdenv.targetPlatform) || stdenv.targetPlatform.isiOS | |||
There was a problem hiding this comment.
It looks like you just copied this line from the 8.4.4.nix, but if you know why stdenv.targetPlatform.isMusl && stdenv.hostPlatform != stdenv.targetPlatform is needed, it'd be really great to have a comment here.
Why is LLVM needed only when we're cross-compiling to musl?
There was a problem hiding this comment.
That was an oversight from rebasing, remove it now.
matthewbauer
force-pushed
the
ios-with-xcode-11-cherry-pick-for-1909
branch
from
e7856c8
to
a10ffa5
Compare
Apple no longer ships with it, so best to avoid forcing it into use.
Even when building for the simulator.
matthewbauer
force-pushed
the
ios-with-xcode-11-cherry-pick-for-1909
branch
from
a10ffa5
to
036cef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @