Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/3proxy: manual validation fix #76069

Merged
merged 1 commit into from Dec 20, 2019
Merged

nixos/3proxy: manual validation fix #76069

merged 1 commit into from Dec 20, 2019

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Dec 19, 2019

nix-build nixos/release.nix -A manual.x86_64-linux is ok with this fix.

See #67507 (comment)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli

@flokli
Copy link
Contributor

flokli commented Dec 19, 2019

Thanks, this fixes the issue.

Is it intentional the module is using services._3proxy for config (with the underscore)?

@misuzu
Copy link
Contributor Author

misuzu commented Dec 19, 2019

Thanks, this fixes the issue.

Is it intentional the module is using services._3proxy for config (with the underscore)?

Yes. Just services.3proxy is invalid and services."3proxy" might not be obvious to use. No one had any concerns with services._3proxy so...

@flokli flokli merged commit e46abc6 into NixOS:master Dec 20, 2019
@misuzu misuzu deleted the package-3proxy branch April 22, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@misuzu @flokli