Do not depend on pangox_compat #75909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to HEAD to not depend on broken pangox-compat.
* Long overdue update * Clean up the expression * Drop unneeded pangox_compat – it was probably needed before gtkglext propagated it.
It was probably needed before gtkglext propagated it.
Drop unneeded pangox_compat – it was probably needed before gtkglext propagated it. Also stop using aliases.
It was probably needed before gtkglext propagated it.
ofborg
bot
requested review from
AndersonTorres,
7c6f434c,
mogorman and
grwlf
jtojnar
force-pushed
the
gtkglext-fix
branch
from
1f7d4d9
to
c3bc037
Compare
|
Hmmph, 😄 as usual I wish nothing needed |
worldofpeace
approved these changes
Dec 19, 2019
|
I think even trying to remove |
jonringer
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
diff LGTM
[242 built (2 failed), 351 copied (3026.1 MiB), 673.8 MiB DL]
error: build of '/nix/store/203mf6w1mwgdvvdlp2cv1zksvcxn4wsk-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/75909
1 package are marked as broken and were skipped:
openmodelica
2 package failed to build:
anydesk gnash
8 package were built:
celestia desmume factor-lang gnome2.gtkglext k3d lutris lutris-free pcb
This was referenced Dec 20, 2019
Merged
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 23, 2020
Do not depend on pangox_compat (cherry picked from commit 76c526a)
balodja
added a commit
to balodja/nixpkgs
that referenced
this pull request
Apr 24, 2021
balodja
added a commit
to balodja/nixpkgs
that referenced
this pull request
May 12, 2021
balodja
added a commit
to balodja/nixpkgs
that referenced
this pull request
Jul 23, 2021
Most of them are: * separate packages for different openmodelica components, * qt4 -> qt5, * patches to instruct the OMEdit wrapper with stdenv executables location, * adoption of NixOS#89731 and NixOS#109595, * openblas -> blas, lapack according to NixOS#83888, * parallel building, * getting rid of spurious build phases, * correct the license, * cross-compilation, * forcing compiler to clang++ according to OM build recommendations, * drop of pangox_compat according to NixOS#75909 and NixOS#76412, * better dependencies, and more.
balodja
added a commit
to balodja/nixpkgs
that referenced
this pull request
Jul 24, 2021
Co-authored-by: Jaakko Luttinen <jaakko.luttinen@iki.fi> Most of changes are: * separate packages for different openmodelica components, * qt4 -> qt5, * patches to instruct the OMEdit wrapper with stdenv executables location, * adoption of NixOS#89731 and NixOS#109595, * openblas -> blas, lapack according to NixOS#83888, * parallel building, * getting rid of spurious build phases, * correct the license, * cross-compilation, * forcing compiler to clang++ according to OM build recommendations, * drop of pangox_compat according to NixOS#75909 and NixOS#76412, * better dependencies, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pangorecently brokepangox_compatpackage but most packages do not actually need it – they were probably only adding it becausegtkglextrequired it. We switched to master branch of gtkglext which fixes lot of issues and also no longer requires pangox.gnome2.gtkglextpcbk3dlutrisdesmumeanydeskopenmodelicaanydeskseems to be an exception:but what can we expect from unfree software 😜️
openmodelicaseems to fail for unrelated reasons:Fixes: #75790