Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hplip: python2 -> python3 #75910

Merged
merged 2 commits into from Dec 19, 2019
Merged

hplip: python2 -> python3 #75910

merged 2 commits into from Dec 19, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 19, 2019 •
edited

Tested with a local HP printer

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from ttuegel December 19, 2019 01:03
worldofpeace
worldofpeace reviewed Dec 19, 2019
View reviewed changes
pkgs/misc/drivers/hplip/default.nix
@@ -68,7 +68,7 @@ python2Packages.buildPythonApplication {
pkgconfig
];

pythonPath = with python2Packages; [
pythonPath = with python3Packages; [
dbus
pillow
pygobject2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really use old pygobject bindings? I feel like this dependency would be really out of date (something something 2010)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a distros.dat file that suggests you can use different version of that library pygobject3.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're good :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamc Sometime I amaze myself. (reading back my comments, I wonder was it really me who typed it?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happens to me all the time as well :(

@grahamc grahamc moved this from WIP to Needs review in Python 2 deprecation Dec 19, 2019
@grahamc
Copy link
Member Author

grahamc commented Dec 19, 2019

Fixed!

@ofborg ofborg bot requested a review from vrthra December 19, 2019 03:16
@worldofpeace
Copy link
Contributor

@grahamc I tested a few binaries and got an import error dbus.service. I believe we're missing dbus-python. I first thought it was there but the with python3Packages had me fooled on the attr name.

@worldofpeace
Copy link
Contributor

worldofpeace commented Dec 19, 2019 •
edited

I see calls to this library too from rg https://github.com/nir0s/distro.

worldofpeace
worldofpeace approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's granted the superficial good enough badge from me @worldofpeace 🥇

@worldofpeace
Copy link
Contributor

I hopefully can exercise the patience for CI here.

@grahamc
Copy link
Member Author

grahamc commented Dec 19, 2019

Force pushed to drop a mailutil commit.

jonringer
jonringer approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[3 built, 2 copied (1.3 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75910
2 package were built:
hplip hplipWithPlugin

@grahamc grahamc merged commit 35b5655 into NixOS:master Dec 19, 2019
Python 2 deprecation automation moved this from Needs review to Done Dec 19, 2019
@grahamc grahamc deleted the python3/hplip branch December 19, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
Python 2 deprecation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @worldofpeace @jonringer