Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neo-cowsay: init at 1.0.0 #75883

Merged
merged 1 commit into from Jan 6, 2020
Merged

neo-cowsay: init at 1.0.0 #75883

merged 1 commit into from Jan 6, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 18, 2019 •
edited

Motivation for this change

https://github.com/Code-Hex/Neo-cowsay/releases/tag/v1.0.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested a review from kalbasit December 18, 2019 17:04
jonringer
jonringer approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM (1 small suggestion)
commits LGTM
executable works (hate it, and love it)

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75883
1 package were built:
neo-cowsay

pkgs/tools/misc/neo-cowsay/default.nix Show resolved Hide resolved
@marsam marsam merged commit a357963 into NixOS:master Jan 6, 2020
@Br1ght0ne Br1ght0ne deleted the neo-cowsay-1.0.0 branch January 6, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Br1ght0ne @jonringer @marsam