nixosTests.gnome3-flashback: init #71212

worldofpeace · 2019-10-16T00:20:31Z

Motivation for this change

Test script is identical to the ancient one we have for gnome3-xorg, but at least by having this we'll catch things like #71210, and just testing the session is convenient on GitHub.

Has #71210 because you can't actually test the tests without it.
(please merge that first).

Things done

Haven't tested the tests yet 😄, as I have to run all three of them.

worldofpeace · 2019-10-16T00:22:52Z

Perhaps I should move the session tests into a subdir gnome3

flashback.nix
xorg.nix
default.nix (wayland default)

I might also want to hold off merging right away, the test script could be more flashback specific and check if those components are ok.

worldofpeace · 2019-10-18T23:58:02Z

@GrahamcOfBorg eval

jtojnar · 2019-10-19T11:34:25Z

nixos/tests/gnome3/flashback.nix

+
+    services.xserver.enable = true;
+
+    services.xserver.displayManager.gdm.enable = false;


Could you add a comment why this is done? I do not think git blame will carry to the original file

Hmm, it seems in the gnome3-xorg test, and in the past gnome3 module enabled gdm and then it got removed and this got added. And I've copied it here.

Actual issue with why we don't test with gdm is #66443.

Yeah, link there should be enough.

GDM doesn't have any way to specify a default session, and I'm guessing it will happily launch wayland sessions even though GDM itself runs X11. Think I switched the test to LightDM when adding wayland support since I didn't manage to get it launch the correct session.

We'd probably have to do something with AccountsService to get it working.

Huh, that's weird, GDM X11 does indeed launch an X11 session, never mind me.

Yeah, I wasn't sure why I was seeing error: unable to open display ":0.0" when using xwininfo. Only thing I thought of was it using wayland? But it was explicitly disabled.

@hedning You're actually correct, setting xserver default will have no effects on gdm.
So we do need to set it with accountsservice over dbus.

worldofpeace · 2019-10-19T23:17:24Z

Ok, so the feature to use different wm with gnome-flashback doesn't work as expected.

So for example, with i3, it doesn't work without i3 installed because it needs its desktop file to launch required components. And even if I do this, none of the flashback components are visible (or maybe I just don't understand i3). And with xmonad there's no desktop file so it shows the "fail whale" requesting you to logout. (and gnome-flashback components are tiled)

I don't really get why things have to be done in this way, can't you just do gnome-flashback+wm with x11?

@jtojnar Has this ever worked?

jtojnar · 2019-10-19T23:24:01Z

I am pretty sure it worked.

We are creating the desktop file here:

https://github.com/NixOS/nixpkgs/pull/53695/files#diff-eccb87703abad3f98a3c3e5c15584083R110-R125

worldofpeace · 2019-10-19T23:31:29Z

Weird... I'll look closer, perhaps it has something to do with systemd sessions.

jtojnar · 2019-10-19T23:32:54Z

I don't really get why things have to be done in this way, can't you just do gnome-flashback+wm with x11?

The idea of #39871 was we would get rid of the old xserver module and just use DMs with session files.

This reverts commit 60aedad. Using tests from NixOS#71212 I am now unable to reproduce there being issues with starting the default metacity flashback session without this.

worldofpeace · 2019-10-20T00:10:28Z

Ok, so testing with bspwm appears to give some more apparent failures.

[  121.326242] gnome-session[851]: gnome-session-binary[851]: WARNING: Application 'bspwm.desktop' failed to register before timeout
[  121.333065] gnome-session-binary[851]: Unrecoverable failure in required component bspwm.desktop
[  121.338569] gnome-session-binary[851]: WARNING: Application 'bspwm.desktop' failed to register before timeout

^ that happens and we get the fail whale, though I can clearly see bspwm running fine.

worldofpeace · 2019-10-20T23:18:33Z

Going to quote what I told @jtojnar in a pm on IRC

btw, just tested gnome-flashback with bspwm and there's no issues with gnome-session 3.32. in 3.34 it's broken though
so maybe autostarts and non-systemd sessions probably have some sort of regression

So I'm thinking because we see the message

WARNING: Application 'bspwm.desktop' failed to register before timeout

it considers bspwm.desktop an Application, even though we set it to start at the windowmanager phase. So somehow in 3.34.x X-GNOME-Autostart-Phase isn't working?

This reverts commit 60aedad. Using tests from #71212 I am now unable to reproduce there being issues with starting the default metacity flashback session without this.

These are terminal tests identical to the gnome3-xorg test for various gnome flashback configurations.

worldofpeace · 2019-11-06T03:24:58Z

@jtojnar I disabled the other tests and just made the metacity one available. We should get to reporting the issues with those sessions to gnome-session eventually. (hopefully before 20.03).

worldofpeace · 2019-11-06T03:43:20Z

@GrahamcOfBorg test gnome3-flashback.metacity

jtojnar · 2019-11-12T00:45:18Z

nixos/tests/gnome3/flashback.nix

@@ -0,0 +1,98 @@
+# GNOME Flashback Terminal tests for various custom sessions.


Yeah, they pretty much test if a terminal shows up.
Btw, I've pretty much rewritten this entirely locally. Though there's issues with the python testing driver and other ports preventing me from re-PRing it.

stale · 2020-06-01T04:24:23Z

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the
related code and @ mention them in a comment.
Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
irc.freenode.net.

worldofpeace · 2020-06-18T00:13:34Z

yep, it's stale. I have a branch with it rewritten, just haven't gotten to PR'ing.

ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 8.has: module (update) labels Oct 16, 2019

worldofpeace force-pushed the gnome-flashback-test branch from 8ac8a81 to 116abc0 Compare October 16, 2019 00:52

worldofpeace requested review from jtojnar and hedning October 18, 2019 23:58

jtojnar reviewed Oct 19, 2019

View reviewed changes

worldofpeace mentioned this pull request Oct 19, 2019

Revert "nixos/gnome3: fix gnome-flashback" #71410

Merged

10 tasks

peti pushed a commit that referenced this pull request Oct 21, 2019

Revert "nixos/gnome3: fix gnome-flashback"

37b1a39

This reverts commit 60aedad. Using tests from #71212 I am now unable to reproduce there being issues with starting the default metacity flashback session without this.

worldofpeace added 2 commits November 5, 2019 22:19

nixosTests.gnome3-flashback: init

9eb3a26

These are terminal tests identical to the gnome3-xorg test for various gnome flashback configurations.

nixos/tests/gnome3: reorganize

43d38ac

worldofpeace force-pushed the gnome-flashback-test branch from 0e89379 to 43d38ac Compare November 6, 2019 03:21

nixos/tests/gnome3: add comment about failing gdm in x11

f7fed7d

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 0 and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: module (update) labels Nov 6, 2019

worldofpeace mentioned this pull request Nov 7, 2019

nixos/gnome3: add gnome-flashback to systemd.packages #72959

Merged

10 tasks

jtojnar reviewed Nov 12, 2019

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020

worldofpeace closed this Jun 18, 2020

worldofpeace deleted the gnome-flashback-test branch June 18, 2020 00:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nixosTests.gnome3-flashback: init #71212

nixosTests.gnome3-flashback: init #71212

worldofpeace commented Oct 16, 2019

worldofpeace commented Oct 16, 2019 •

edited

worldofpeace commented Oct 18, 2019

jtojnar Oct 19, 2019

worldofpeace Oct 19, 2019

jtojnar Oct 19, 2019

hedning Oct 20, 2019

hedning Oct 20, 2019

worldofpeace Oct 20, 2019

worldofpeace Nov 6, 2019 •

edited

worldofpeace commented Oct 19, 2019

jtojnar commented Oct 19, 2019

worldofpeace commented Oct 19, 2019

jtojnar commented Oct 19, 2019

worldofpeace commented Oct 20, 2019

worldofpeace commented Oct 20, 2019

worldofpeace commented Nov 6, 2019

worldofpeace commented Nov 6, 2019

jtojnar Nov 12, 2019

worldofpeace Nov 12, 2019

stale bot commented Jun 1, 2020

worldofpeace commented Jun 18, 2020


		services.xserver.enable = true;

		services.xserver.displayManager.gdm.enable = false;

		@@ -0,0 +1,98 @@
		# GNOME Flashback Terminal tests for various custom sessions.

nixosTests.gnome3-flashback: init #71212

nixosTests.gnome3-flashback: init #71212

Conversation

worldofpeace commented Oct 16, 2019

Motivation for this change

Things done

worldofpeace commented Oct 16, 2019 • edited

worldofpeace commented Oct 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

worldofpeace Nov 6, 2019 • edited

Choose a reason for hiding this comment

worldofpeace commented Oct 19, 2019

jtojnar commented Oct 19, 2019

worldofpeace commented Oct 19, 2019

jtojnar commented Oct 19, 2019

worldofpeace commented Oct 20, 2019

worldofpeace commented Oct 20, 2019

worldofpeace commented Nov 6, 2019

worldofpeace commented Nov 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Jun 1, 2020

worldofpeace commented Jun 18, 2020

worldofpeace commented Oct 16, 2019 •

edited

worldofpeace Nov 6, 2019 •

edited