Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.praw: 6.3.1 -> 6.4.0 #71276

Merged
merged 2 commits into from Oct 20, 2019
Merged

python3Packages.praw: 6.3.1 -> 6.4.0 #71276

merged 2 commits into from Oct 20, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 17, 2019 •
edited

Motivation for this change

closes #70743

freezes python2 version so it still builds

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built (4 failed), 106 copied (185.0 MiB), 66.7 MiB DL]
error: build of '/nix/store/mfmsw7nwbanjdpgzrijh06n2hbpyd7gy-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/71276
2 package failed to build:
python38Packages.praw python38Packages.sopel

2 package were build:
python37Packages.praw python37Packages.sopel

@jonringer jonringer requested a review from FRidh as a code owner October 17, 2019 04:37
@mmahut
Copy link
Member

mmahut commented Oct 19, 2019

@GrahamcOfBorg build python37Packages.praw python38Packages.praw

@jonringer
Copy link
Contributor Author

python38Packages.pytest is broken...

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.praw python27Packages.praw

@risicle
Copy link
Contributor

risicle commented Oct 20, 2019

Builds happily on macos 10.13/py37

@jonringer jonringer merged commit 6f89c01 into NixOS:master Oct 20, 2019
@jonringer jonringer deleted the bump-praw branch October 20, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @mmahut @risicle @FRidh