Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfsbackup: init at unstable-2019-03-05 #71284

Merged
merged 4 commits into from Oct 26, 2019
Merged

zfsbackup: init at unstable-2019-03-05 #71284

merged 4 commits into from Oct 26, 2019

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Oct 17, 2019 •
edited

Motivation for this change

I'm interested in using zfsbackup on my NixOS server, and figured this may as well be upstream. The installation instructions outright say to use nightly, so that's what I do - the upstream tags are ancient.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@KamilaBorowska KamilaBorowska force-pushed the zfsbackup-go branch 4 times, most recently from 2a0dc2b to ecf2e5d Compare October 17, 2019 12:47
@KamilaBorowska KamilaBorowska changed the title zfsbackup-go: init at unstable-2019-03-05 zfsbackup: init at unstable-2019-03-05 Oct 17, 2019
@risicle
Copy link
Contributor

risicle commented Oct 20, 2019

nix-review is happy, macos 10.13, binary executes.

markuskowa
markuskowa reviewed Oct 24, 2019
View reviewed changes
pkgs/tools/backup/zfsbackup/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/zfsbackup/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/zfsbackup/default.nix Outdated Show resolved Hide resolved
markuskowa
markuskowa reviewed Oct 26, 2019
View reviewed changes
pkgs/tools/backup/zfsbackup/default.nix Outdated

goPackagePath = "github.com/someone1/zfsbackup-go";

src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the sources are on GitHub it should be FetchFromGitHub here instead of fetchgit.

@ofborg ofborg bot requested a review from ehmry October 26, 2019 13:34
@markuskowa
Copy link
Member

@GrahamcOfBorg build zfsbackup

@markuskowa markuskowa merged commit 4c0afa1 into NixOS:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

@markuskowa markuskowa Awaiting requested review from markuskowa

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KamilaBorowska @risicle @markuskowa @ehmry