Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ppx_tools: enable at 5.3+4.08.0 for OCaml 4.09 #71313

Merged
merged 2 commits into from
Oct 25, 2019
Merged

ocamlPackages.ppx_tools: enable at 5.3+4.08.0 for OCaml 4.09 #71313

merged 2 commits into from
Oct 25, 2019
+7 −0

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 18, 2019

Motivation for this change

Compatibility with OCaml 4.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

vbgl added 2 commits October 18, 2019 06:20
@vbgl
ocamlPackages.camlp4: fix evaluation for OCaml ≥ 4.09

Verified

This commit was signed with the committer’s verified signature. The key has expired.
rycee Robert Helgesson
GPG key ID: 36BDAA14C2797E89
Expired
Verified
Learn about vigilant mode
896150b
@vbgl
ocamlPackages.ppx_tools: enable at 5.3+4.08.0 for OCaml 4.09
d86be7d
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 18, 2019
@vbgl
Copy link
Contributor Author

vbgl commented Oct 18, 2019

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_09.nocrypto

@vbgl vbgl merged commit 0c2aa9d into NixOS:master Oct 25, 2019
@vbgl vbgl deleted the ocaml-ppx_tools-4.09 branch October 25, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl