Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeoffice: 970 -> 971 #71225

Merged
merged 1 commit into from Oct 16, 2019
Merged

freeoffice: 970 -> 971 #71225

merged 1 commit into from Oct 16, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Oct 16, 2019 •
edited

Motivation for this change

The sha256 sum has changed upstream.

Edit: Upstream has replaced the source for version 970 with the source for version 971. Therefore this is a version bump. See comments below.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @danieldk

@danieldk
Copy link
Contributor

This seems to be the hash of the new release (971). They seem to replace the older version as well. So, maybe you could also bump up the version?

I have also posted on their forum to ask if they can keep older tarballs as-is:

https://forum.softmaker.com/viewtopic.php?f=320&t=19327

@romildo
Copy link
Contributor Author

romildo commented Oct 16, 2019

Turned it into a version bump.

@danieldk
Copy link
Contributor

Looks good to me:

  • Tested build
  • Tested all programs

@romildo romildo changed the title freeoffice: fix sha256 freeoffice: 970 -> 971 Oct 16, 2019
@romildo romildo merged commit 3a44087 into NixOS:master Oct 16, 2019
@romildo romildo deleted the fix.freeoffice branch October 16, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @danieldk