Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prototool: 1.8.0 -> 1.9.0 #71224

Merged
merged 1 commit into from Oct 20, 2019
Merged

prototool: 1.8.0 -> 1.9.0 #71224

merged 1 commit into from Oct 20, 2019

Conversation

johnchildren
Copy link
Contributor

@johnchildren johnchildren commented Oct 16, 2019 •
edited

Motivation for this change

Minor version update available

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @marsam

@ofborg ofborg bot requested review from kalbasit and marsam October 16, 2019 11:06
@multun
Copy link
Member

multun commented Oct 16, 2019

Does not work for me, am I doing something wrong?

$ nix-shell -p nix-review --run "nix-review pr 71224"
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/71224/head:refs/nix-review/1
$ git worktree add /home/multun/.cache/nix-review/pr-71224-1/nixpkgs 6695d3f08f213976b781fa0a3b12f665b1857414
Preparing worktree (detached HEAD 6695d3f08f2)
Updating files: 100% (20037/20037), done.
HEAD is now at 6695d3f08f2 Merge pull request #71200 from Shopify/seb-libgda-mac
$ git merge --no-commit f812f8948bf42ecb860ccb3c5b2968bf342a435e
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/multun/.cache/nix-review/pr-71224-1/build.nix
building '/nix/store/32bv0i159s4607wrfhqq55xyjlm51y3h-prototool-1.9.0-go-modules.drv'...
hash mismatch in fixed-output derivation '/nix/store/0qha3qmr9rjzhvpyhi2ww5r3q7fl7bbp-prototool-1.9.0-go-modules':
  wanted: sha256:1y3gy8ya37zp8kpyic4kslgwfmjkm31iq1j8q4k3sbyz0pr1ljb3
  got:    sha256:0n4bi78ih2lla4xxy7m3bg1nq64qc84jfg5kxsdw186rxivk7jmm
[...]

Another run gives

hash mismatch in fixed-output derivation '/nix/store/gzs0pggdgg70aipxw6ms2cd3arrqrvaw-prototool-1.9.0-go-modules':
  wanted: sha256:1y3gy8ya37zp8kpyic4kslgwfmjkm31iq1j8q4k3sbyz0pr1ljb3
  got:    sha256:1l6j3ixn667xv8y2kwps9y7li6hl9d4x90pdjjcxa1gly5plxff7

It looks like each run outputs a different hash.

@marsam
Copy link
Contributor

marsam commented Oct 16, 2019

@multun buildGoModule with go1.13 is yielding different hashes. See #71049

@johnchildren
Copy link
Contributor Author

Ah that explains why then! Had some weird behavior locally when I was trying to override nixpkgs with this version. Should I close this for now and make a new one after the issue is fixed or leave it open?

@marsam
Copy link
Contributor

marsam commented Oct 18, 2019

let's leave this open, I hope to merge the buildGoModule fix in the next couple of days

@marsam
Copy link
Contributor

marsam commented Oct 20, 2019

@johnchildren thanks for you patience, would you mind rebasing onto master?

@johnchildren
Copy link
Contributor Author

Thank you, have rebased and fixed the modSha256!

@multun
Copy link
Member

multun commented Oct 20, 2019

LGTM, tested with sandboxing

@marsam marsam merged commit eb7a680 into NixOS:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multun multun multun approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnchildren @multun @marsam