Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/nmigen
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 045f5e19a225
Choose a base ref
...
head repository: m-labs/nmigen
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fb9004346025
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Oct 16, 2019

  1. lib.io: use keyword-only arguments in Pin().

    whitequark committed Oct 16, 2019
    Copy the full SHA
    fb90043 View commit details
Showing with 2 additions and 2 deletions.
  1. +1 −1 nmigen/build/res.py
  2. +1 −1 nmigen/lib/io.py
2 changes: 1 addition & 1 deletion nmigen/build/res.py
Original file line number Diff line number Diff line change
@@ -134,7 +134,7 @@ def resolve(resource, dir, xdr, name, attrs):
if dir == "-":
pin = None
else:
pin = Pin(len(phys), dir, xdr, name=name)
pin = Pin(len(phys), dir, xdr=xdr, name=name)

for phys_name in phys_names:
if phys_name in self._phys_reqd:
2 changes: 1 addition & 1 deletion nmigen/lib/io.py
Original file line number Diff line number Diff line change
@@ -97,7 +97,7 @@ class Pin(Record):
cannot change direction more than once per cycle, so at most one output enable signal
is present.
"""
def __init__(self, width, dir, xdr=0, name=None, src_loc_at=0):
def __init__(self, width, dir, *, xdr=0, name=None, src_loc_at=0):
self.width = width
self.dir = dir
self.xdr = xdr