Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xournalpp: 1.0.12 -> 1.0.15 #71217

Merged
merged 1 commit into from Oct 18, 2019
Merged

xournalpp: 1.0.12 -> 1.0.15 #71217

merged 1 commit into from Oct 18, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Oct 16, 2019

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/4fw7drb3amadqlh9khjylwisxsk3cx3f-xournalpp-1.0.12
/nix/store/4fw7drb3amadqlh9khjylwisxsk3cx3f-xournalpp-1.0.12	 217.2M
$ nix path-info -Sh /nix/store/97wyhgp655qgb8bwlsn74i1m7vgiy0ad-xournalpp-1.0.15
/nix/store/97wyhgp655qgb8bwlsn74i1m7vgiy0ad-xournalpp-1.0.15	 189.1M
Notify maintainers

cc @andrew-d

@ofborg ofborg bot requested a review from andrew-d October 16, 2019 07:48
andrew-d
andrew-d approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@andrew-d andrew-d left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! The only breaking change is renaming the desktop & icon files, which shouldn't affect NixOS. Thanks!

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 18, 2019

@GrahamcOfBorg build xournalpp

@c0bw3b c0bw3b merged commit c1e21ab into NixOS:master Oct 18, 2019
@sikmir sikmir deleted the xournalpp branch October 18, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-d andrew-d andrew-d approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @c0bw3b @andrew-d