Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.purescript-language-server: init at 0.12.7 #71215

Closed
wants to merge 3 commits into from
Closed

nodePackages.purescript-language-server: init at 0.12.7 #71215

wants to merge 3 commits into from

Conversation

justinlovinger
Copy link
Contributor

Motivation for this change

Add purescript-language-server. Required for language server clients like coc.nvim to work with PureScript.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@adisbladis adisbladis self-assigned this Oct 18, 2019
@veprbl veprbl requested review from marsam and Amar1729 and removed request for Amar1729 February 9, 2020 23:14
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@NickHu
Copy link
Contributor

NickHu commented Jun 28, 2020

Whoops, I believe this is superseded by #91438 (I should've looked before making a PR). I'll close this now.

@NickHu NickHu closed this Jun 28, 2020
@justinlovinger
Copy link
Contributor Author

@NickHu No problem :) I'm just glad it's in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@marsam marsam Awaiting requested review from marsam

Assignees

@adisbladis adisbladis

Labels
2.status: merge conflict 6.topic: nodejs 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@justinlovinger @prusnak @NickHu @adisbladis @veprbl