Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime: 20190521 -> 20191018 #71316

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Oct 18, 2019

Motivation for this change

this upgrade fixes a problem with running trapping WebAssembly code
for me:

error: failed to process main module `_out/issue36.wasm`
    caused by: Instantiation error: Trap occurred while invoking start function: wasm trap: unreachable, source location: @2eb9
Note

I had trouble building this on our darwin builder, and probably need help here:

  = note: Undefined symbols for architecture x86_64:
            "_utimensat", referenced from:
                _$LT$$u5b$u8$u5d$$u20$as$u20$nix..NixPath$GT$::with_nix_path::h2c1b78ca714c817b in wasi_common-cb01afa41255bfe8.wasi_common.2pp5p6tf-cgu.12.rcgu.o
          ld: symbol(s) not found for architecture x86_64
          clang-7: error: linker command failed with exit code 1 (use -v to see invocation)

Is it using libsystem features not available on nix?

I am not sure if this is a regression.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer

this upgrade fixes a problem with running trapping WebAssembly code
for me:

```
error: failed to process main module `_out/issue36.wasm`
    caused by: Instantiation error: Trap occurred while invoking start function: wasm trap: unreachable, source location: @2eb9
```
@nomeata
Copy link
Contributor Author

nomeata commented Oct 18, 2019

I notified upstream about the darwin build issue: https://github.com/CraneStation/wasi-common/issues/132

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 20, 2019

On Hydra it has been failing to build on aarch64 and darwin forever.
It should be restricted to x86 linux platforms.

@nomeata
Copy link
Contributor Author

nomeata commented Oct 21, 2019

Upstream is working at least on the darwin support, maybe it’ll be available soon.

@matthewbauer matthewbauer merged commit ff12e10 into NixOS:master Nov 7, 2019
@nomeata nomeata deleted the bump-wasmtime branch November 7, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants