Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: split compiling instructions from README, as they aren't requir… #7778

Merged
merged 1 commit into from Oct 19, 2019
Merged

Doc: split compiling instructions from README, as they aren't requir… #7778

merged 1 commit into from Oct 19, 2019

Conversation

andythenorth
Copy link
Contributor

…ed for casual GitHub visitors

@nielsmh
Copy link
Contributor

nielsmh commented Oct 17, 2019

I'd keep a headline about Compiling in the Readme, and just point readers to the Compiling file.

@andythenorth andythenorth force-pushed the split-out-compiling-instructions branch 7 times, most recently from 7e4f6d0 to 422eff6 Compare October 17, 2019 19:42
@andythenorth andythenorth changed the title Docs: split compiling instructions from README, as they aren't requir… Doc: split compiling instructions from README, as they aren't requir… Oct 17, 2019
LordAro
LordAro reviewed Oct 17, 2019
View reviewed changes
COMPILING.md Outdated Show resolved Hide resolved
@andythenorth andythenorth force-pushed the split-out-compiling-instructions branch 12 times, most recently from bbcfa71 to fe032ce Compare October 17, 2019 20:53
LordAro
LordAro requested changes Oct 17, 2019
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing too awful

COMPILING.md Outdated Show resolved Hide resolved
COMPILING.md Outdated Show resolved Hide resolved
COMPILING.md Show resolved Hide resolved
COMPILING.md Outdated Show resolved Hide resolved
COMPILING.md Outdated Show resolved Hide resolved
COMPILING.md Outdated Show resolved Hide resolved
COMPILING.md Outdated Show resolved Hide resolved
COMPILING.md Outdated Show resolved Hide resolved
glx22
glx22 reviewed Oct 18, 2019
View reviewed changes
COMPILING.md Outdated Show resolved Hide resolved
@andythenorth andythenorth force-pushed the split-out-compiling-instructions branch 4 times, most recently from af0a766 to b43da49 Compare October 18, 2019 17:18
@andythenorth andythenorth force-pushed the split-out-compiling-instructions branch from b43da49 to 8344cb1 Compare October 18, 2019 20:46
@LordAro LordAro merged commit e5f1755 into OpenTTD:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 left review comments

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andythenorth @nielsmh @glx22 @LordAro