Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2019.09.28 -> 2019.10.16 #71213

Merged
merged 1 commit into from Oct 17, 2019
Merged

youtube-dl: 2019.09.28 -> 2019.10.16 #71213

merged 1 commit into from Oct 17, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Oct 16, 2019 •
edited

Motivation for this change

Update youtube-dl to the latest release.

NOTE: Updates to youtube-dl should be backported, thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bluescreen303 @Phreedom @AndersonTorres @Fuuzetsu @fpletz @Enzime

jonringer
jonringer approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (2 broken on master)
diff LGTM
executable seems to work

[23 built (2 failed), 98 copied (536.3 MiB), 153.5 MiB DL]
error: build of '/nix/store/svcslcc5qvznbjh27431qv9p913h8hb0-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/71213
2 package failed to build:
deepin.dde-file-manager plex-media-player

21 package were build:
bomi celluloid curseradio deepin.deepin-movie-reborn kodi-cli lollypop minitube mopidy-youtube mpc-qt mpv mpv-with-scripts persepolis python27Packages.pafy python27Packages.youtube-dl python27Packages.youtube-dl-light python37Packages.mps-youtube python37Packages.mpv python37Packages.pafy youtube-dl youtube-dl-light ytcc

@jonringer jonringer merged commit 8b079c2 into NixOS:master Oct 17, 2019
@xrelkd xrelkd deleted the update/youtube-dl branch October 17, 2019 03:11
@xrelkd
Copy link
Contributor Author

xrelkd commented Oct 17, 2019

@jonringer Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@Phreedom Phreedom Awaiting requested review from Phreedom

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @jonringer