Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] Coq 8.10.0 #71214

Merged
merged 5 commits into from Oct 23, 2019
Merged

[19.09] Coq 8.10.0 #71214

merged 5 commits into from Oct 23, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 16, 2019 •
edited

Motivation for this change

Ports to branch “release-19.09” commits from #70629, #68894, and #70642

This also disables CoqIDE on darwin at version 8.10.0 as it cannot be built with GTK3 at version 3.24.10.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vbgl and others added 5 commits October 16, 2019 04:01
@vbgl
coq_8_10: do not build CoqIDE on darwin
bb75840 
See https://gitlab.gnome.org/GNOME/gtk/merge_requests/1004
for details about the GTK3 issue
@vbgl
coq_8_10: 8.10+β2 → 8.10+β3
2e37793 
(cherry picked from commit 8288301)
@vbgl
coq_8_10: do not take “camlp5” as input
090dccf 
(cherry picked from commit 1292f49)
@maggesi @vbgl
elpi: 1.6.0 -> 1.7.0
46b2ba1 
(cherry picked from commit c70d7fa)
@vbgl
coq_8_10: 8.10+β3 → 8.10.0
0da40a1 
coqPackages.coq-elpi: master → 1.1.0

(cherry picked from commit b4db381)
@vbgl vbgl merged commit 37082f6 into NixOS:release-19.09 Oct 23, 2019
@vbgl vbgl deleted the coq-8.10.0+release-19.09 branch October 23, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@Zimmi48 Zimmi48 Zimmi48 approved these changes

@roconnor roconnor Awaiting requested review from roconnor

Assignees
No one assigned
Labels
6.topic: coq 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @thoughtpolice @Zimmi48 @maggesi