Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticsearchPlugins: add analysis-icu plugin #71235

Merged
merged 1 commit into from Feb 26, 2020
Merged

elasticsearchPlugins: add analysis-icu plugin #71235

merged 1 commit into from Feb 26, 2020

Conversation

nbr
Copy link
Member

@nbr nbr commented Oct 16, 2019 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @apeschar @basvandijk

nbr
nbr commented Oct 16, 2019
View reviewed changes
pkgs/servers/search/elasticsearch/plugins.nix Outdated
Comment on lines 20 to 23
# Work around the "unpacker appears to have produced no directories"
# case that happens when the archive doesn't have a subdirectory.
setSourceRoot = "sourceRoot=`pwd`";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from pkgs/tools/misc/ent/default.nix

@nbr nbr marked this pull request as ready for review October 16, 2019 15:08
@ofborg ofborg bot requested a review from offlinehacker October 16, 2019 15:19
@nbr nbr requested a review from basvandijk February 18, 2020 15:54
@nbr nbr force-pushed the elasticsearch-analysis-icu branch 4 times, most recently from 9e428cf to 97b30bd Compare February 18, 2020 16:22
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build elasticsearchPlugins.analysis-icu

@worldofpeace
Copy link
Contributor

This PR is good to merge after #71235 (comment) is pushed.

@worldofpeace
Copy link
Contributor

@nbr Can you fixup your history with interactive rebase to have one commit elasticsearchPlugins: add analysis-icu plugin?

@nbr nbr force-pushed the elasticsearch-analysis-icu branch from b15e4fb to 6e23a3a Compare February 25, 2020 14:54
@nbr nbr force-pushed the elasticsearch-analysis-icu branch from 6e23a3a to c1e376e Compare February 25, 2020 15:05
@nbr
Copy link
Member Author

nbr commented Feb 25, 2020

@nbr Can you fixup your history with interactive rebase to have one commit elasticsearchPlugins: add analysis-icu plugin?

@worldofpeace Done. Thanks for guiding this PR through.

@worldofpeace worldofpeace merged commit a89a919 into NixOS:master Feb 26, 2020
@marsam marsam mentioned this pull request Jul 19, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@basvandijk basvandijk Awaiting requested review from basvandijk

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nbr @worldofpeace