Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh-history: Update gomod hashsum #71226

Closed
wants to merge 0 commits into from
Closed

zsh-history: Update gomod hashsum #71226

wants to merge 0 commits into from
+0 −0

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Oct 16, 2019

Motivation for this change

SHA256 checksum of gomod dependencies does not match on master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @teto

Sorry, something went wrong.

@kampka kampka mentioned this pull request Oct 16, 2019
Merged
10 tasks
@teto
Copy link
Member

teto commented Oct 16, 2019

@GrahamcOfBorg build zsh-history

@teto
Copy link
Member

teto commented Oct 16, 2019

seems to fail on my nixos-unstable fork. Let's see how ofbord does

@ofborg ofborg bot requested a review from kalbasit October 16, 2019 11:22
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 16, 2019
@kampka
Copy link
Contributor Author

kampka commented Oct 16, 2019

Well, I have no idea whats going on here. I had to generate the hashsum three times over for it converge in nix-review after using the one ofBorg originally wanted.
Fingers crossed it's good now.

@teto
Copy link
Member

teto commented Oct 16, 2019

@GrahamcOfBorg build zsh-history

@teto
Copy link
Member

teto commented Oct 16, 2019

what sometimes happen to me is that I first develop a package in an overlay and then move it to my nixpkgs but it still builds the version from the overlay xD.
Looks like it is stiff failing

@kampka
Copy link
Contributor Author

kampka commented Oct 16, 2019

@GrahamcOfBorg build zsh-history

1 similar comment
@teto
Copy link
Member

teto commented Oct 16, 2019

@GrahamcOfBorg build zsh-history

@teto
Copy link
Member

teto commented Oct 16, 2019

strange, the build succeeds once, the same hash is wrong for the 2 other tests, but wrong against 2 different values xD I don't know enough about the go ecosystem so let's wait for a more adept reviewer :(

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/76

@kampka
Copy link
Contributor Author

kampka commented Dec 9, 2019

@GrahamcOfBorg build zsh-history

@kampka kampka closed this Dec 9, 2019
@kampka
Copy link
Contributor Author

kampka commented Dec 9, 2019

@GrahamcOfBorg build zsh-history

1 similar comment
@teto
Copy link
Member

teto commented Dec 9, 2019

@GrahamcOfBorg build zsh-history

@kampka
Copy link
Contributor Author

kampka commented Dec 9, 2019

@teto I believe this might have been fixed with golang 1.13 but now the checksum turns back to the value we had before which means there is no change here. That's why GH closed this issue automatically and ofBorg does not longer build it.
Hydra however seems to build it just fine: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.zsh-history.x86_64-linux#tabs-status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @teto @nixos-discourse