Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atheme: init at 7.2.10-r2 #71247

Merged
merged 1 commit into from Oct 18, 2019
Merged

atheme: init at 7.2.10-r2 #71247

merged 1 commit into from Oct 18, 2019

Conversation

leo60228
Copy link
Member

@leo60228 leo60228 commented Oct 16, 2019 •
edited

Motivation for this change

I wanted it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • N/A: Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • N/A: Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • N/A: Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@leo60228
Copy link
Member Author

wait, i accidentally included another package i was working on...

@leo60228 leo60228 changed the title atheme: init at 7.2.9 atheme: init at 7.2.10-r2 Oct 16, 2019
@mweinelt
Copy link
Member

mweinelt commented Oct 16, 2019 •
edited 

$ results/atheme/bin/ecdsakeygen 
I'm sorry, you didn't compile Atheme with OpenSSL support.

should actually look somewhat like this

$ ./ecdsakeygen 
Keypair:
    Private-Key: (256 bit)
    priv:
        1f:9c:54:43:5c:45:e1:8d:93:e0:df:e0:a3:7e:9f:
        41:d6:dd:41:4d:a6:ff:fa:be:41:18:8e:02:46:c9:
        03:c0
    pub:
        02:aa:31:c4:4d:10:c5:ff:67:33:cf:40:ce:71:f2:
        f0:2a:bb:88:88:9f:49:a7:e1:25:15:20:0b:21:68:
        43:2c:6f
    ASN1 OID: prime256v1
    NIST CURVE: P-256
Private key:
-----BEGIN EC PRIVATE KEY-----
MFcCAQEEIB+cVENcReGNk+Df4KN+n0HW3UFNpv/6vkEYjgJGyQPAoAoGCCqGSM49
AwEHoSQDIgACqjHETRDF/2czz0DOcfLwKruIiJ9Jp+ElFSALIWhDLG8=
-----END EC PRIVATE KEY-----
Public key (atheme format):
AqoxxE0Qxf9nM89AznHy8Cq7iIifSafhJRUgCyFoQyxv

Guess you need to add OpenSSL to build inputs.

@mweinelt
Copy link
Member

Maybe also enable some features along the way.

  --with-pcre             Enable PCRE regular expression support
  --with-libidn           Compile with GNU libidn for SASL SCRAM-SHA support.
  --with-cracklib         Compile NickServ cracklib module for checking
                          password strength
  --enable-large-net      Enable large network support.
  --enable-contrib        Enable contrib modules.
  --enable-reproducible-builds
                          Enable reproducible builds.

mweinelt
mweinelt reviewed Oct 16, 2019
View reviewed changes
pkgs/servers/atheme/default.nix Outdated
@@ -0,0 +1,24 @@
{ stdenv, fetchgit, libmowgli, pkgconfig, git, gettext }:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add with lib; here and shorten the stdenv.lib in meta.

@leo60228
Copy link
Member Author

I've moved it to pkgs/servers/irc/atheme.

mweinelt
mweinelt reviewed Oct 17, 2019
View reviewed changes
pkgs/servers/irc/atheme/default.nix
"--enable-reproducible-builds"
];

src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this up, so it is between version and nativeBuildInputs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src is now between configureFlags and nativeBuildInputs. Can you move configureFlags after src?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@flokli flokli merged commit a45785a into NixOS:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@flokli flokli flokli left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leo60228 @mweinelt @flokli