Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] nixos/pppd: init #71271

Merged
merged 4 commits into from Jan 10, 2020
Merged

[19.09] nixos/pppd: init #71271

merged 4 commits into from Jan 10, 2020

Conversation

danderson
Copy link
Contributor

Motivation for this change

This is a backport of a standalone service module, which is disabled by default. It enables people who need PPP connections (i.e. me :) ) to use NixOS 19.09 as a router.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fooker
Copy link
Contributor

fooker commented Nov 7, 2019

The peers option is mission a description. This results in warning.

@danderson danderson force-pushed the release-19.09 branch 2 times, most recently from 0ec7122 to 50a6c26 Compare December 8, 2019 01:19
@danderson
Copy link
Contributor Author

Added additional cherry-pick to fix the warning.

@andir
Copy link
Member

andir commented Dec 12, 2019

@GrahamcOfBorg test pppd

@danderson
Copy link
Contributor Author

Tests look good, can we merge this?

danderson and others added 4 commits January 1, 2020 19:27
@danderson
maintainers: add danderson
e753695 
(cherry picked from commit c5c5baf)
@danderson
nixos/pppd: init
b485113 
(cherry picked from commit 997a6f6)
@danderson
nixos/tests/pppd: init
40b1860 
This test creates a PPPoE link between two machines, and verifies
that the machines can ping each other.

(cherry picked from commit ae02b3d)
@FRidh @danderson
nixos/pppd: add description for peers, unbreaks metrics job and channel
b563ba0 
services.pppd.peers was lacking a description, causing a trace warning
resulting in a parse error in the metrics job.

(cherry picked from commit 0256080)
@danderson
Copy link
Contributor Author

Rebased to the top of latest release-19.09, checks still pass.

@mweinelt
Copy link
Member

Tested today and works just fine.

@andir andir merged commit 01423cb into NixOS:release-19.09 Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danderson @fooker @andir @mweinelt @FRidh