Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rngd: Start early during boot and encrypted swap entropy fix #71302

Merged
merged 2 commits into from Feb 12, 2020
Merged

rngd: Start early during boot and encrypted swap entropy fix #71302

merged 2 commits into from Feb 12, 2020

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Oct 17, 2019 •
edited

Motivation for this change

Intended to fix entropy starvation during boot (fixes #71204)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar

@abbradar
Copy link
Member

Interesting, thanks! I'll be able to review this in the upcoming week.

(Sorry for the absence, had a fun traveling accident which greatly prolonged my vacation :D)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-are-your-goals-for-20-03/4773/15

@tokudan
Copy link
Contributor Author

tokudan commented Feb 6, 2020

Squashed a commit and rebased onto the current master

@tokudan tokudan changed the title rngd: Start early during boot and encrypted swap entropy fix [WIP] rngd: Start early during boot and encrypted swap entropy fix Feb 6, 2020
@tokudan
Copy link
Contributor Author

tokudan commented Feb 6, 2020

I believe this is ready for review/merging

@tokudan
swap: depend on rngd if enabled and randomEncryption is configured to
1ac86e1 
avoid entropy starvation during boot
@tokudan
security.rngd: start rngd during early boot to reduce entropy starvat…
d14ba1e 
…ion due to encrypted swap and remove PrivateTmp to avoid a circular dependency
rnhmjoj
rnhmjoj approved these changes Feb 8, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/97

@tokudan tokudan mentioned this pull request Feb 11, 2020
Merged
10 tasks
@rnhmjoj rnhmjoj merged commit 48704fb into NixOS:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[19.09] swapDevices.*.randomEncryption possible entropy starvation during boot
5 participants
@tokudan @abbradar @nixos-discourse @grahamc @rnhmjoj