Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage-access-api] create META.yml #19729

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Oct 16, 2019

No description provided.

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip
Copy link
Member Author

foolip commented Oct 16, 2019

@Brandr0id are you a good reviewer for this directory? It looks like there's no spec at all for this, is that right?

Copy link
Member

@Brandr0id Brandr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foolip
Copy link
Member Author

foolip commented Nov 7, 2019

@Brandr0id I see you don't have write access to the repo, which will be a problem because your reviews won't result in a green checkmark and a mergable PR. I've invited you to the reviewers team, you should see a banner at the top of https://github.com/web-platform-tests or find something in your inbox.

I'll hold off merging this, because wpt-pr-bot won't be able to assign you as a reviewer unless you're a member of the org.

@Brandr0id
Copy link
Member

Thanks, should be all good now. Looks like the status on this PR has updated already.

@foolip foolip merged commit 05a4dc9 into master Nov 7, 2019
@foolip foolip deleted the foolip/storage-access-api-meta branch November 7, 2019 22:40
@foolip
Copy link
Member Author

foolip commented Nov 7, 2019

Yep, I've merged now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants