Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.netcdf4: fix hdf5 dependency #71312

Closed
wants to merge 1 commit into from
Closed

pythonPackages.netcdf4: fix hdf5 dependency #71312

wants to merge 1 commit into from

Conversation

dylex
Copy link
Contributor

@dylex dylex commented Oct 18, 2019

After 6cbf0b4 split hdf5 dev output, pythonPackages.netcdf4 broke:

ValueError: did not find HDF5 headers in /nix/store/1cxjxca3r2vd1r5s8bhcccjhricsq10a-hdf5-1.10.5/include

This fixes the HDF5_DIR setting for netcdf4 to use hdf5.dev instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dylex dylex requested a review from FRidh as a code owner October 18, 2019 03:32
@FRidh
Copy link
Member

FRidh commented Oct 18, 2019

Please check staging-next branch because I recall having seen changes related to this.

@dylex
Copy link
Contributor Author

dylex commented Oct 18, 2019

Ah, yes, I see a1b0992 should address this. Sorry -- it often seems like there are many places to look for fixes so I never know where to submit PRs (like staging, staging-next, haskell-updates, master).

@dylex dylex closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dylex @FRidh