Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitkraken: 6.2.1 -> 6.3.0 #71294

Merged
merged 3 commits into from Oct 18, 2019
Merged

gitkraken: 6.2.1 -> 6.3.0 #71294

merged 3 commits into from Oct 18, 2019

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Oct 17, 2019

Motivation for this change

https://support.gitkraken.com/release-notes/current/#version-630

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @xNWDD

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 18, 2019

dpkg should be in nativeBuildInputs if it is only necessary to unpack deb package at build time.

Also when overriding installPhase it should start with runHook preInstall and end with runHook postInstall

@evanjs
Copy link
Member Author

evanjs commented Oct 18, 2019

Thanks!
Seems to work fine after the changes.

c0bw3b
c0bw3b approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on my end too (nixos)

@c0bw3b c0bw3b merged commit 9deca47 into NixOS:master Oct 18, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/explicit-runhook-in-derivation/4614/7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanjs @c0bw3b @nixos-discourse